[hotfix] Fix deprecated apis OriginalType class and checkNotNull method in paimon-format realted to parquet #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wayneguow Please open your action in your repo too. https://github.com/wayneguow/paimon/actions |
|
Mhm. I forgot this. Thank your for reminding me. @JingsongLi |
wayneguow
force-pushed
the
fix_parquet_deprecated
branch
from
b0a8b5d to
7d12806
Compare
|
GA in my fork repo seems passed: https://github.com/wayneguow/paimon/actions?query=branch%3Afix_parquet_deprecated, Can we move it forward? @JingsongLi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix deprecated apis
OriginalTypeclass andcheckNotNullmethod inpaimon-formatrealted to parquet:Class
org.apache.parquet.schema.OriginalTypeis instead byorg.apache.parquet.schema.LogicalTypeAnnotation, and I noticed that other open source projects closely related to parquet, such asSparkandIceberg, have already switched.Method
org.apache.parquet.Preconditions.checkNotNull()Linked issue: close #3708
Tests
Passed all parquet realated test cases in
paimon-formatsubmodule.API and Format
Documentation