[core] Support delete by default in partial updates #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfengzhou-hub
force-pushed
the
ISSUE-3048-delete-partial-update
branch
from
97bbab5 to
e2fa258
Compare
|
Hi @JingsongLi Could you please take a look at this PR? |
yunfengzhou-hub
force-pushed
the
ISSUE-3048-delete-partial-update
branch
4 times, most recently
from
791d3bf to
dfd50df
Compare
JingsongLi
reviewed
Jul 16, 2024
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
ISSUE-3048-delete-partial-update
branch
from
dfd50df to
7fd2a5d
Compare
|
Thanks for the comments @JingsongLi. I have updated the PR according to the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3048
This pull request supports dealing with deletion records in partial update merge engine.
Tests
Unit tests are added in PrimaryKeyFileStoreTableTest to verify the changes in this PR
API and Format
This pull request affects the default behavior of partial-update merge engine in cases where deletion records exist. Given that the existing behavior is to throw exception in this case, the changes in this PR are backward compatible.
Documentation
This PR requires to update the document about merge engine, which has been included in the commit.