[core] Update possible reasons for commit conflicts #3518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Jun 16, 2024
| @@ -1130,7 +1129,8 @@ private Pair<RuntimeException, RuntimeException> createConflictException( | |||
| "3. You're recovering from an old savepoint, or you're creating multiple jobs from a savepoint.", | |||
| " The job will fail continuously in this scenario to protect metadata from corruption.", | |||
| " You can either recover from the latest savepoint, " | |||
| + "or you can revert the table to the snapshot corresponding to the old savepoint."); | |||
| + "or you can revert the table to the snapshot corresponding to the old savepoint.", | |||
| "4. The parallelism of committer, or the parallelism of compact coordinator (for append only scalable table) is not 1."); | |||
There was a problem hiding this comment.
We don't need this if we have runtime check.
JingsongLi
reviewed
Jun 16, 2024
| + "(most probably due to checkpoint timeout).", | ||
| " See https://paimon.apache.org/docs/master/maintenance/write-performance/ " | ||
| + "for how to improve writing performance.", | ||
| "1. Data is written into expired partitions.", |
There was a problem hiding this comment.
Maybe we can check delete files and know it is the true reason?
|
Also related to #3340. |
This was referenced Aug 12, 2024
|
Fixed in #3945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We recently found that, if data is written into expired partitions, commit conflicts may occur.
It is not easy to completely work around this scenario, so currently we prefer users to filter out expired data by themselves. This PR updates possible reasons for commit conflicts to remind the users.
Tests
No tests.
API and Format
No API changes.
Documentation
No new features.