Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Serializers were created infinitely and caused OOM for 0.8 #3460

Closed
1 of 2 tasks
xccui opened this issue Jun 1, 2024 · 4 comments · Fixed by #3484
Closed
1 of 2 tasks

[Bug] Serializers were created infinitely and caused OOM for 0.8 #3460

xccui opened this issue Jun 1, 2024 · 4 comments · Fixed by #3484
Assignees
Labels
bug Something isn't working

Comments

@xccui
Copy link
Member

xccui commented Jun 1, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Paimon version

0.8

Compute Engine

Flink 1.18.1

Minimal reproduce step

Serializers were created infinitely for the following recursive schema after bumping up Paimon to 0.8.

ARRAY <
    ROW <
        `null_value` STRING,
        `number_value` DOUBLE,
        `string_value` STRING,
        `bool_value` BOOLEAN,
        `struct_value` ROW <
            `fields` ARRAY <
                ROW <
                    `key` STRING,
                    `value` ROW <
                        `null_value` STRING,
                        `number_value` DOUBLE,
                        `string_value` STRING,
                        `bool_value` BOOLEAN,
                        `struct_value` ROW <
                            `fields` ARRAY <
                                ROW <
                                    `key` STRING,
                                    `value` ROW <
                                        `null_value` STRING,
                                        `number_value` DOUBLE,
                                        `string_value` STRING,
                                        `bool_value` BOOLEAN
                                    >
                                > NOT NULL
                            >
                        >,
                        `list_value` ROW <
                            `values` ARRAY <
                                ROW <
                                    `null_value` STRING,
                                    `number_value` DOUBLE,
                                    `string_value` STRING,
                                    `bool_value` BOOLEAN
                                > NOT NULL
                            >
                        >
                    >
                > NOT NULL
            >
        >,
        `list_value` ROW <
            `values` ARRAY <
                ROW <
                    `null_value` STRING,
                    `number_value` DOUBLE,
                    `string_value` STRING,
                    `bool_value` BOOLEAN,
                    `struct_value` ROW <
                        `fields` ARRAY <
                            ROW <
                                `key` STRING,
                                `value` ROW <
                                    `null_value` STRING,
                                    `number_value` DOUBLE,
                                    `string_value` STRING,
                                    `bool_value` BOOLEAN
                                >
                            > NOT NULL
                        >
                    >,
                    `list_value` ROW <
                        `values` ARRAY <
                            ROW <
                                `null_value` STRING,
                                `number_value` DOUBLE,
                                `string_value` STRING,
                                `bool_value` BOOLEAN
                            > NOT NULL
                        >
                    >
                > NOT NULL
            >
        >
    > NOT NULL
>

What doesn't meet your expectations?

The test case worked well with Paimon 0.7 but caused OOM with Paimon 0.8.
image

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@xccui xccui added the bug Something isn't working label Jun 1, 2024
@wg1026688210
Copy link
Contributor

Hi~ @xccui Could you please specify when the OOM occurred? Was it during the data writing process?

@xccui
Copy link
Member Author

xccui commented Jun 3, 2024

Hi @wg1026688210, it happened when I tried to write something to a Paimon table. Here's the screenshot for the stack.

image

@xccui
Copy link
Member Author

xccui commented Jun 5, 2024

I think the bug was introduced in #3039 since everything's back to normal after I reverted it.
CC @JingsongLi

@wg1026688210
Copy link
Contributor

Hi @wg1026688210, it happened when I tried to write something to a Paimon table. Here's the screenshot for the stack.

image

Hi ~ @xccui Could you provide the code reproducing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants