Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark] Spark3.2 insertoverwrite test support #3458

Merged
merged 11 commits into from
Jun 3, 2024

Conversation

xuzifu666
Copy link
Member

@xuzifu666 xuzifu666 commented Jun 1, 2024

Add test for insertoverwrite for Spark3.2

Linked issue: #3459

Test and verify for insertoverwrite for Spark3.2

API and Format

Documentation

import org.apache.spark.sql.Row
import org.apache.spark.sql.types._

class InsertOverwriteTest extends PaimonSparkTestBase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this test same to DeleteFromTableTest? We can have a InsertOverwriteTestBase in spark common.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,do it latter


package org.apache.paimon.spark.sql

class InsertOverwriteTableTest extends InsertOverwriteTest {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to other spark version module too

@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit 0e226c6 into apache:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants