Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix should ignore the Long.MIN value when create TAG based on … #3457

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

LinMingQiang
Copy link
Contributor

@LinMingQiang LinMingQiang commented May 31, 2024

…the watermark.

Purpose

Linked issue: close #3346

CREATE TEMPORARY TABLE testTag ( 
id STRING  
,name STRING 
,dt STRING 
,PRIMARY KEY(id, dt) NOT ENFORCED 
) PARTITIONED BY (dt) WITH ( 
,'connector' = 'paimon' 
.......
'tag.automatic-creation'='watermark',
'tag.creation-period'='hourly',
'tag.creation-delay' = '10 s', 
'tag.num-retained-max' = '90', 
)

When the watermark value is Long.MIN_VALUE, the tag will be created with name tag-1705471-09-26 16.

Tests

API and Format

Documentation

@LinMingQiang
Copy link
Contributor Author

LinMingQiang commented May 31, 2024

@JingsongLi Do you have time to review this pr for me? thanks.

@JingsongLi
Copy link
Contributor

test triggered

@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit 013a50d into apache:master Jun 3, 2024
9 checks passed
JingsongLi pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自动创建Tags的Bug
2 participants