[PIP-22] Introduce repair metastore procedure #3355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
requested changes
May 21, 2024
paimon-core/src/main/java/org/apache/paimon/catalog/Catalog.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/catalog/Catalog.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/catalog/Catalog.java
Outdated
Show resolved
Hide resolved
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| default void repairTable(Identifier identifier) throws TableNotExistException { |
There was a problem hiding this comment.
Querying the paimon table by identifier in the file system may not exist. TableNotExistException is the exception thrown on the getDataTable method.
...on-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/sink/cdc/CdcRecordUtils.java
Outdated
Show resolved
Hide resolved
...on-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/sink/cdc/CdcRecordUtils.java
Outdated
Show resolved
Hide resolved
...ink/paimon-flink-common/src/main/java/org/apache/paimon/flink/procedure/RepairProcedure.java
Outdated
Show resolved
Hide resolved
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
Outdated
Show resolved
Hide resolved
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
Outdated
Show resolved
Hide resolved
|
Thanks @zhuangchong , left some comments. |
|
Thanks. @JingsongLi |
JingsongLi
reviewed
May 22, 2024
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
Outdated
Show resolved
Hide resolved
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
Show resolved
Hide resolved
|
I added a new test
|
JingsongLi
pushed a commit
to JingsongLi/paimon
that referenced
this pull request
May 24, 2024
|
+1 |
sunxiaojian
pushed a commit
to sunxiaojian/paimon
that referenced
this pull request
May 28, 2024
joyCurry30
pushed a commit
to joyCurry30/paimon
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce repair metastore procedure
Tests
HiveCatalogITCaseBase#testRepairTable
API and Format
Documentation