Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdc] Calculated columns support constant value. #3156

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

zhuangchong
Copy link
Contributor

@zhuangchong zhuangchong commented Apr 3, 2024

Purpose

Linked issue: close #3097

Tests

API and Format

Documentation

@zhuangchong zhuangchong requested a review from yuzelin April 7, 2024 03:18
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhuangchong .

Can you investigate other systems?
An intuitive feeling is that we can enrich types, not just strings, for example, strings need to be '11', and 11 is an int.

@zhuangchong zhuangchong requested a review from JingsongLi April 8, 2024 09:50
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 6f512c0 into apache:master Apr 10, 2024
10 checks passed
@zhuangchong
Copy link
Contributor Author

Thanks. @JingsongLi

@zhuangchong zhuangchong deleted the add_cdc_calculated_columns branch April 10, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Calculated columns support constant value
2 participants