[format]Set orc.compression.zstd.level to 3 by default #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update documentation too? |
JingsongLi
reviewed
Mar 29, 2024
| <td>Integer</td> | ||
| <td>Define the compression level to use with ZStandard codec while writing data. The valid range is 1~22.</td> | ||
| </tr> | ||
| <tr> | ||
| <td><h5>orc.compression.zstd.windowlog</h5></td> |
There was a problem hiding this comment.
See OrcOptions, there is no orc.compression.zstd.windowlog.
There was a problem hiding this comment.
See OrcOptions, there is no orc.compression.zstd.windowlog.
Paimon OrcOptions is useless at the moment.
According to org.apache.paimon.format.orc.OrcWriterFactory#getWriterOptions
org.apache.orc.OrcFile.WriterOptions convert form writerProperties direct,
and orc.compression.zstd.windowlog is support by OrcFile.WriterOptions.
There was a problem hiding this comment.
OrcOptions is used to generate documentation.
|
+1 |
zhu3pang
pushed a commit
to zhu3pang/incubator-paimon
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set orc.compression.zstd.level to 3 by default