[cdc] Refactor DebeziumRecordParser #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzelin
changed the title
zhuangchong
reviewed
Jan 25, 2024
Comment on lines
186
to
188
|
|
||
| Map<String, String> recordMap = | ||
| JsonSerdeUtil.convertValue(record, new TypeReference<Map<String, String>>() {}); |
There was a problem hiding this comment.
There is a risk here. When the data is a complex type (such as array), json parsing will be abnormal.
yuzelin
force-pushed
the
add_more_schema_type
branch
from
06c3043 to
9d58d71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
debezium-json with schema should handle type like mysql record parser.
And we should not add a new format, just use 'debezium-json'
This PR is enhancement of #2706
Tests
API and Format
Documentation