Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Introduce UpgradeStrategy to simplify logical #2781

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

JingsongLi
Copy link
Contributor

Purpose

Continue #2751

Tests

API and Format

Documentation

@JingsongLi JingsongLi changed the title [core] Introduce UpgradeChangelog to simplify logical [core] Introduce UpgradeStrategy to simplify logical Jan 24, 2024
@@ -77,8 +80,19 @@ protected boolean rewriteChangelog(
}

@Override
protected boolean upgradeChangelog(int outputLevel, DataFileMeta file) {
return file.level() == 0;
protected UpgradeStrategy upgradeChangelog(int outputLevel, DataFileMeta file) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this overwrite is no need

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class is not extended lookup rewriter.

@Zouxxyy
Copy link
Contributor

Zouxxyy commented Jan 24, 2024

+1

@JingsongLi JingsongLi merged commit 9c53136 into apache:master Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants