Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add a Chinese version for the documentation #2718

Closed
wants to merge 4 commits into from

Conversation

Waterkin
Copy link

Purpose

Linked issue: open #2708

Add a Chinese version for the documentation, while new Chinese files (stored in docs/content.zh) are still the same in English (stored in docs/content), needing further translation.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Waterkin

Do not just copy all documentation files. We should do translation one by one.

@Waterkin
Copy link
Author

Hi @JingsongLi

I've added an entrance to the new Chinese version at the sidebar, so people can simply focus on the translations of English content at docs/content.zh. For example, people can just revise these contents and submit a PR online, making translations more convenient. The convenience will make translation, which is a huge work, easier.

@JingsongLi
Copy link
Contributor

Hi @JingsongLi

I've added an entrance to the new Chinese version at the sidebar, so people can simply focus on the translations of English content at docs/content.zh. For example, people can just revise these contents and submit a PR online, making translations more convenient. The convenience will make translation, which is a huge work, easier.

Do not copy without translation which makes maintenance very difficult, and the result is not yet any benefit.

@Waterkin
Copy link
Author

@JingsongLi Do you think it ok that I delete the copyed files and only translate some of them?

@JingsongLi
Copy link
Contributor

@JingsongLi Do you think it ok that I delete the copyed files and only translate some of them?

Yes, that is a better way.

@Waterkin
Copy link
Author

@JingsongLi PTAL, thanks!

@JingsongLi
Copy link
Contributor

Hi @Waterkin , very thanks for your contribution.

But it is really hard to maintain two documentation. It is recommended to use translator to read english documentation.

@JingsongLi JingsongLi closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants