Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flink] fix bug for show partitions with date and time type #2513

Closed
wants to merge 1 commit into from
Closed

[flink] fix bug for show partitions with date and time type #2513

wants to merge 1 commit into from

Conversation

zhangjun0x01
Copy link
Contributor

Purpose

now ,show partitions with date type partition will show number, we should show correct date format.

Tests

API and Format

Documentation

JingsongLi
JingsongLi reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know yes, it's bad here, but due to compatibility issues we kept the date display, not so good to change it here to show it this way, which will cause some experiential issues.

@JingsongLi
Copy link
Contributor

Thanks @zhangjun0x01 , but I think it is better to think whole story here.

@JingsongLi JingsongLi closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangjun0x01 @JingsongLi