Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Execute ManifestFileMeta#merge asynchronously to reduce the time of snapshot commit. #2483

Open
2 tasks done
liming30 opened this issue Dec 11, 2023 · 2 comments
Open
2 tasks done

[Feature] Execute ManifestFileMeta#merge asynchronously to reduce the time of snapshot commit. #2483

liming30 opened this issue Dec 11, 2023 · 2 comments
Assignees
@liming30
Labels
enhancement New feature or request

Comments

@liming30
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

In the snapshot commit phase, ManifestFileMeta will be merged. Consider this situation: when a partition expires, fullCompaction will be triggered according to the merge algorithm. At this time, all historical ManifestEntry will be rewritten into the new ManifestFile, and the time will increase with the number of ManifestEntry.

I tested about 20 * 40000 ManifestEntry and it took about 5 minutes.

Solution

I think the merge of ManifestFileMeta can also be executed asynchronously like compaction.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@liming30 liming30 added the enhancement New feature or request label Dec 11, 2023
@liming30
Copy link
Contributor Author

@JingsongLi WDYT?

@JingsongLi
Copy link
Contributor

I think it is reasonable.

@liming30 liming30 self-assigned this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liming30 liming30

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JingsongLi @liming30