Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support TableScan.close to clean scan resources #2122

Closed
2 tasks done
schnappi17 opened this issue Oct 12, 2023 · 1 comment
Closed
2 tasks done

[Feature] Support TableScan.close to clean scan resources #2122

schnappi17 opened this issue Oct 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@schnappi17
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

We'll measure scan operations by introducing scan metrics, the metric groups will be in the JVM. In the resident JVM like flink session cluster, the metric groups should be cleaned in the right time. Like scan resources, we should clean them by SplitEnumerator closes.

Solution

Add close() method in the TableScan interface first.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@schnappi17 schnappi17 added the enhancement New feature or request label Oct 12, 2023
@schnappi17 schnappi17 mentioned this issue Oct 12, 2023
Closed
@schnappi17
Copy link
Contributor Author

close this by refactoring metric system: #2169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Support TableScan resources clean schnappi17/flink-table-store
1 participant
@schnappi17