Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimize the memory usage of PartitionExpire. #2023

Closed
1 of 2 tasks
liming30 opened this issue Sep 15, 2023 · 2 comments
Closed
1 of 2 tasks

[Feature] Optimize the memory usage of PartitionExpire. #2023

liming30 opened this issue Sep 15, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@liming30
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

  1. When the partition expires, all ManifestEntry of the corresponding partition will be read into the memory, and then a new ManifestEntry whose FileKind is Delete will be generated. When the file of the expired partition is very large (hundreds of thousands), this will occupy a lot of memory.

  2. In addition, when there may be conflicts in the commit, the files of the changed partitions will also be read into the memory for conflict checking.

Solution

We may not need to read it completely into memory, but return it in a stream.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@liming30 liming30 added the enhancement New feature or request label Sep 15, 2023
@xiangyuf
Copy link
Contributor

@liming30 hi, could u pls assign this issue to me?

@JingsongLi
Copy link
Contributor

Already optimized in the 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants