[flink] add table comment for create table in sync action #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Aug 28, 2023
| @@ -79,13 +79,13 @@ static Connection getConnection(Configuration mySqlConfig, boolean tinyint1NotBo | |||
| throws Exception { | |||
| String url = | |||
| String.format( | |||
| "jdbc:mysql://%s:%d%s", | |||
| "jdbc:mysql://%s:%d?useInformationSchema=true%s", | |||
There was a problem hiding this comment.
Should we use an option to open this feature?
I don't know how much impact it has in performance.
There was a problem hiding this comment.
the param in default true in mysql 8.0.3 (doc) ,but it is default false in mysql 5.7, if we add an option and when we set it to false ,do we should set it to false explicitly in mysql8 ?
There was a problem hiding this comment.
Or default we can just disable table comments.
zhangjun0x01
force-pushed
the
add_table_comment_for_sync
branch
2 times, most recently
from
e0c02d7 to
7dea8cd
Compare
zhangjun0x01
force-pushed
the
add_table_comment_for_sync
branch
from
7dea8cd to
a39151d
Compare
|
Already supported, I will close this PR first. If you have any questions, you can open it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
in flink sync action , sync the table comment when create new table.
Tests
API and Format
Documentation