From 9e98cda5bfac2ad8b9d9374e0d1e7f23c244cba8 Mon Sep 17 00:00:00 2001
From: yuzelin <33053040+yuzelin@users.noreply.github.com>
Date: Thu, 20 Jun 2024 17:58:06 +0800
Subject: [PATCH] [core] Explain tag.num-retained-max (#3555)
---
docs/layouts/shortcodes/generated/core_configuration.html | 4 ++--
.../src/main/java/org/apache/paimon/CoreOptions.java | 7 +++++--
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/docs/layouts/shortcodes/generated/core_configuration.html b/docs/layouts/shortcodes/generated/core_configuration.html
index 862f614eedae..e57becbab96d 100644
--- a/docs/layouts/shortcodes/generated/core_configuration.html
+++ b/docs/layouts/shortcodes/generated/core_configuration.html
@@ -754,13 +754,13 @@
tag.default-time-retained |
(none) |
Duration |
- The default maximum time retained for newly created tags. |
+ The default maximum time retained for newly created tags. It affects both auto-created tags and manually created (by procedure) tags. |
tag.num-retained-max |
(none) |
Integer |
- The maximum number of tags to retain. |
+ The maximum number of tags to retain. It only affects auto-created tags. |
tag.period-formatter |
diff --git a/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java b/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java
index 5e8ebb264cc1..36a2a2af2946 100644
--- a/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java
+++ b/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java
@@ -1057,13 +1057,16 @@ public class CoreOptions implements Serializable {
key("tag.num-retained-max")
.intType()
.noDefaultValue()
- .withDescription("The maximum number of tags to retain.");
+ .withDescription(
+ "The maximum number of tags to retain. It only affects auto-created tags.");
public static final ConfigOption TAG_DEFAULT_TIME_RETAINED =
key("tag.default-time-retained")
.durationType()
.noDefaultValue()
- .withDescription("The default maximum time retained for newly created tags.");
+ .withDescription(
+ "The default maximum time retained for newly created tags. "
+ + "It affects both auto-created tags and manually created (by procedure) tags.");
public static final ConfigOption SNAPSHOT_WATERMARK_IDLE_TIMEOUT =
key("snapshot.watermark-idle-timeout")