From 1d80aac69ec2ee211bc1a6a195cf975cfb08ec27 Mon Sep 17 00:00:00 2001 From: wgcn <1026688210@qq.com> Date: Wed, 28 Feb 2024 15:27:34 +0800 Subject: [PATCH] improve --- .../org/apache/paimon/io/IdentifierSerializer.java | 2 +- .../paimon/flink/action/CompactDatabaseAction.java | 3 ++- .../paimon/flink/compact/AbstractBucketScanLogic.java | 11 +++++------ .../apache/paimon/flink/compact/BatchFileScanner.java | 6 ++++-- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/paimon-core/src/main/java/org/apache/paimon/io/IdentifierSerializer.java b/paimon-core/src/main/java/org/apache/paimon/io/IdentifierSerializer.java index c5f298876e055..8ff39f099460d 100644 --- a/paimon-core/src/main/java/org/apache/paimon/io/IdentifierSerializer.java +++ b/paimon-core/src/main/java/org/apache/paimon/io/IdentifierSerializer.java @@ -24,7 +24,7 @@ import org.apache.paimon.data.InternalRow; import org.apache.paimon.utils.ObjectSerializer; -/** Serializer for {@link Identifier}.*/ +/** Serializer for {@link Identifier}. */ public class IdentifierSerializer extends ObjectSerializer { public IdentifierSerializer() { diff --git a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/CompactDatabaseAction.java b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/CompactDatabaseAction.java index e0f4c834fe02d..52d2e8bf2f84d 100644 --- a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/CompactDatabaseAction.java +++ b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/CompactDatabaseAction.java @@ -198,7 +198,8 @@ private void buildForCombinedMode() { excludingPattern, tableOptions.get(CoreOptions.CONTINUOUS_DISCOVERY_INTERVAL).toMillis()); - // multi bucket table which has multi bucket in a partition like fix bucket and dynamic bucket + // multi bucket table which has multi bucket in a partition like fix bucket and dynamic + // bucket DataStream multiBucketTableSource = partition( sourceBuilder diff --git a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/AbstractBucketScanLogic.java b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/AbstractBucketScanLogic.java index 03b3b719934a5..00e25eb3c2ac9 100644 --- a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/AbstractBucketScanLogic.java +++ b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/AbstractBucketScanLogic.java @@ -36,15 +36,14 @@ import static org.apache.paimon.flink.utils.MultiTablesCompactorUtil.shouldCompactTable; /** - * This class is responsible for implementing the scanning logic for the table of different type buckets during - * compaction. + * This class is responsible for implementing the scanning logic for the table of different type + * buckets during compaction. * * @param the result of scanning file : *
    - *
  1. {@link Split} for the table with multi buckets, such as dynamic or fixed - * bucket table. - *
  2. {@link AppendOnlyCompactionTask} for the table witch fixed single - * bucket ,such as unaware bucket table. + *
  3. {@link Split} for the table with multi buckets, such as dynamic or fixed bucket table. + *
  4. {@link AppendOnlyCompactionTask} for the table witch fixed single bucket ,such as + * unaware bucket table. *
*/ public abstract class AbstractBucketScanLogic { diff --git a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/BatchFileScanner.java b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/BatchFileScanner.java index dd74171f3aee9..0974747f4ad65 100644 --- a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/BatchFileScanner.java +++ b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/BatchFileScanner.java @@ -43,9 +43,11 @@ public void scan(SourceFunction.SourceContext ctx) throws Exception { return; } if (isEmpty) { - // Currently, in the combined mode, there are two scan tasks for the table of two different bucket type (multi bucket & unaware bucket) are + // Currently, in the combined mode, there are two scan tasks for the table of two + // different bucket type (multi bucket & unaware bucket) are // running concurrently. - // There will be a situation that there is only one task compaction , therefore this should not be thrown exception here. + // There will be a situation that there is only one task compaction , therefore this + // should not be thrown exception here. LOGGER.info( "No file were collected for the table of {}", tableScanLogic.bucketType()); }