-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] checkpatch fails. #2812
Labels
Type: Bug
Something isn't working
Comments
Sorry @simbit18 do you recall how checkpatch works? I remember seeing this error in the NuttX Repo, I fear that we missed something when syncing the CI Workflow from NuttX Repo to NuttX Apps. Thanks! |
I think we need to sync this from NuttX Repo to NuttX Apps: Update: Yep indeed! I submitted the patch: |
lupyuen
added a commit
to lupyuen2/wip-nuttx-apps
that referenced
this issue
Nov 2, 2024
This PR syncs apache/nuttx#14323 from `nuttx` repo to `nuttx-apps`. This will resolve the `checkpatch.sh` failure: apache#2812
cederom
pushed a commit
that referenced
this issue
Nov 2, 2024
This PR syncs apache/nuttx#14323 from `nuttx` repo to `nuttx-apps`. This will resolve the `checkpatch.sh` failure: #2812
Thank you @lupyuen !! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description / Steps to reproduce the issue
Our CI checkpatch fails on all builds @lupyuen could you please take a look? :-)
https://github.com/apache/nuttx-apps/actions/runs/11628349047/job/32383339856?pr=2808
/bin/sh
link from/bin/bash
to/usr/bin/dash
and DASH is not quite compatible with BASH lol :-) It is safest to use/usr/bin/env bash
now ;-)On which OS does this issue occur?
[OS: Linux]
What is the version of your OS?
GitHub CI Ubuntu?
NuttX Version
master
Issue Architecture
[Arch: all]
Issue Area
[Area: Tools]
Verification
The text was updated successfully, but these errors were encountered: