Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] checkpatch fails. #2812

Closed
1 task done
cederom opened this issue Nov 1, 2024 · 3 comments · Fixed by #2814
Closed
1 task done

[CI] checkpatch fails. #2812

cederom opened this issue Nov 1, 2024 · 3 comments · Fixed by #2814
Assignees
Labels
Type: Bug Something isn't working

Comments

@cederom
Copy link

cederom commented Nov 1, 2024

Description / Steps to reproduce the issue

Our CI checkpatch fails on all builds @lupyuen could you please take a look? :-)

https://github.com/apache/nuttx-apps/actions/runs/11628349047/job/32383339856?pr=2808

Run echo "::add-matcher::nuttx/.github/nxstyle.json"
Collecting cmake-format
  Downloading cmake_format-0.6.13-py3-none-any.whl (19 kB)
Collecting cmakelang>=0.6.13
  Downloading cmakelang-0.6.13-py3-none-any.whl (159 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 159.8/159.8 KB 13.1 MB/s eta 0:00:00
Collecting six>=1.13.0
  Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
Installing collected packages: six, cmakelang, cmake-format
Successfully installed cmake-format-0.6.13 cmakelang-0.6.13 six-1.16.0
ccd3ee983 Merge d2a2621f34c945ee52a4d498f77a4b1650cc48b4 into 242b9473423cd29aa4be6fe8efd4c4f33317bcdd
d2a2621f3 Improve nxdiag example for Espressif devices
../nuttx/tools/checkpatch.sh -m -g 242b9473423cd29aa4be6fe8efd4c4f33317bcdd..HEAD
../nuttx/tools/checkpatch.sh: line 87: black: command not found
../nuttx/tools/checkpatch.sh: line 88: flake8: command not found
../nuttx/tools/checkpatch.sh: line 89: isort: command not found
../nuttx/tools/checkpatch.sh: line 92: isort: command not found
Error: Process completed with exit code 1.
  • If we use Debian/Ubuntu on the build machine I recently noticed they chanhed the /bin/sh link from /bin/bash to /usr/bin/dash and DASH is not quite compatible with BASH lol :-) It is safest to use /usr/bin/env bash now ;-)
  • Maybe missing packages needs to be installed?

On which OS does this issue occur?

[OS: Linux]

What is the version of your OS?

GitHub CI Ubuntu?

NuttX Version

master

Issue Architecture

[Arch: all]

Issue Area

[Area: Tools]

Verification

  • I have verified before submitting the report.
@cederom cederom added the Type: Bug Something isn't working label Nov 1, 2024
@lupyuen
Copy link
Member

lupyuen commented Nov 2, 2024

Sorry @simbit18 do you recall how checkpatch works? I remember seeing this error in the NuttX Repo, I fear that we missed something when syncing the CI Workflow from NuttX Repo to NuttX Apps. Thanks!

@lupyuen
Copy link
Member

lupyuen commented Nov 2, 2024

I think we need to sync this from NuttX Repo to NuttX Apps:

Update: Yep indeed! I submitted the patch:

lupyuen added a commit to lupyuen2/wip-nuttx-apps that referenced this issue Nov 2, 2024
This PR syncs apache/nuttx#14323 from `nuttx` repo to `nuttx-apps`.

This will resolve the `checkpatch.sh` failure: apache#2812
@lupyuen lupyuen linked a pull request Nov 2, 2024 that will close this issue
@lupyuen lupyuen removed a link to a pull request Nov 2, 2024
@lupyuen lupyuen linked a pull request Nov 2, 2024 that will close this issue
cederom pushed a commit that referenced this issue Nov 2, 2024
This PR syncs apache/nuttx#14323 from `nuttx` repo to `nuttx-apps`.

This will resolve the `checkpatch.sh` failure: #2812
@cederom
Copy link
Author

cederom commented Nov 2, 2024

Thank you @lupyuen !! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants