Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to define global cflags in packages #534

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

m-gorecki
Copy link
Contributor

This adds possibility to use global cflags in packages. Until now only cflags defined in app package were used globally while compiling. Now it is possible to add such flags in every package by using "app.cflags" field in package's yaml file. This also adds new command to show which packages within the target contain those global flags.

Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while app.cflags is passed to build it is not put in generated CMakelist.txt

This adds possibility to add global cflags in pkgs.
If one pkg will add app.cflags flag, then all other
pkgs used by a target will also use this flag during compilation.
This command prints all target's packages that contain app.flags
field and it's values. In the future this command
might be extended to show other miscellaneous info about
specified target.
Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK

@kasjer kasjer merged commit 40e37e9 into apache:master Feb 26, 2024
59 checks passed
@m-gorecki m-gorecki deleted the appflags branch November 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants