Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET 8 target for docs generation, #928 #989

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Uses the .NET 8 target for docs generation.

Related: #928

Description

The docs generation was using the net6.0 target as the latest available; as of #982 we now have the net8.0 target, so this updates the docfx json files to use that target instead.

@NightOwl888 NightOwl888 self-requested a review October 23, 2024 22:55
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the build works locally, and it looks like all of the files have been updated with net8.0. This looks good to merge.

@NightOwl888 NightOwl888 merged commit 8242383 into apache:master Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants