Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Lucene.Net.QueryParsers.Classic.QueryParserTokenManager: Removed initialization code that caused writing a BOM to standard out upon creation. Fixes #792. #902

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

NightOwl888
Copy link
Contributor

@NightOwl888 NightOwl888 commented Jan 20, 2024

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

BUG: Lucene.Net.QueryParsers.Classic.QueryParserTokenManager: Removed initialization code that caused writing a BOM to standard out upon creation.

Fixes #792

Description

Removed initialization code that caused writing a BOM to standard out upon creation. This also improves performance by removing an unnecessary allocation of StreamWriter and brings the code in line with Lucene.

… initialization code that caused writing a BOM to standard out upon creation. Fixes apache#792.
@NightOwl888 NightOwl888 merged commit 1e6c80a into apache:master Jan 20, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating QueryParserTokenManager writes to standard output
1 participant