Tests: Review T-Z Tests, #259 #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This addresses some formatting disparities between the Java and C# tests to help make them more line-to-line matching. - Comments added in places where our tests differ from upstream. - RandomizedTesting.Generators extension method import moved behind a `#if !NET6_0_OR_GREATER` check, as the namespace was being ignored on .NET 6+ in a few files since .NET 6 added a Random.NextInt64 method. This will help prevent other contributors from thinking this namespace is not needed. - A unit test assertion bug on arm64 with division by zero is fixed. - The `build` file has been chmod'ed +x for ease of use - Rider IDE files added
NightOwl888
requested changes
Jan 18, 2024
NightOwl888
approved these changes
Jan 22, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test review for the T-Z unit test project.
Associated #259 (doesn't fully fix)
Description
#if !NET6_0_OR_GREATERcheck, as the namespace was being ignored on .NET 6+ in a few files since .NET 6 added a Random.NextInt64 method. This will help prevent other contributors from thinking this namespace is not needed.buildfile has been chmod'ed +x for ease of use