New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnicodeUtil updates: TryUTF8toUTF16, ReadOnlySpan methods, #1024 #1057

Draft

paulirwin wants to merge 3 commits into apache:master from paulirwin:issue/1024

Contributor

paulirwin commented Dec 4, 2024

You've read the Contributor Guide and Code of Conduct.
You've included unit or integration tests for your change, where applicable.
You've included inline docs for your change, where applicable.
There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Add TryUTF8toUTF16 method to UnicodeUtil and update caller, some conversions to ReadOnlySpan

Fixes #1024

Description

This is a draft WIP because I want to make sure I caught all of the cases where this could be used, as well as add a unit test for the new method.


          UnicodeUtil updates: TryUTF8toUTF16, ReadOnlySpan methods, apache#1024

7581aa7

paulirwin added the notes:improvement label

paulirwin requested a review from NightOwl888

December 4, 2024 23:55

paulirwin added 2 commits

December 4, 2024 20:43


          Add back array overloads; add unit test for TryUTF8toUTF16

000f20f


          Fix comment formatting

16ada56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:improvement