Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6281][PY] Enable hive test in python client #6381

Closed
wants to merge 1 commit into from

Conversation

sudohainguyen
Copy link
Contributor

@sudohainguyen sudohainguyen commented May 10, 2024

🔍 Description

Issue References 🔗

This pull request enables running hive test cases in python client, however there's one trivial case not covered yet and two others require a proper container setup

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Hive test disabled in #6343

Behavior With This Pull Request 🎉

Can cover hive test cases

Related Unit Tests

No


Checklist 📝

Be nice. Be informative.

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label May 10, 2024
@github-actions github-actions bot removed the kind:infra license, community building, project builds, asf infra related, etc. label May 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (12c5568) to head (a861382).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6381      +/-   ##
============================================
- Coverage     58.51%   58.48%   -0.03%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39895    39959      +64     
  Branches       5482     5487       +5     
============================================
+ Hits          23345    23372      +27     
- Misses        14055    14079      +24     
- Partials       2495     2508      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sudohainguyen
Copy link
Contributor Author

@pan3793 please take a look when you have time 🙏

@pan3793 pan3793 added this to the v1.10.0 milestone May 15, 2024
@pan3793 pan3793 closed this in 06af125 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants