Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFM meta parser ignores blank lines; this is non-standard #73

Open
sebbASF opened this issue Jun 14, 2023 · 1 comment
Open

GFM meta parser ignores blank lines; this is non-standard #73

sebbASF opened this issue Jun 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@sebbASF
Copy link
Contributor

sebbASF commented Jun 14, 2023

The GFM reader skips blank lines when parsing meta-data.
This is in contrast with the standard Pelican parsers which treat a blank line as the end of the meta-data block.

This matters because:

  • it is non-standard
  • the parser can treat the start of body content as a meta-data item, if the body starts with something that looks like a keyword. This is unlikely, but not impossible.

It looks as though this behaviour has been relied on in some ASF website sources, in particular the main website.

Some options are:

  • just document the behaviour
  • add an option to warn if such blank lines are found
  • add an option to disable the behaviour
@sebbASF sebbASF added the bug Something isn't working label Jun 14, 2023
@sebbASF
Copy link
Contributor Author

sebbASF commented Jun 15, 2023

Just noticed that some ASF pages contain a line starting with 'Note: '.
There don't seem to be any pages where this is the first non-blank line, but it could easily be the case.

Obviously there are work-rounds, but it might not be obvious to the editor why their page was misbehaving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant