Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation for Migrate DB On StartUp and Jobs Approach #544

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Initial implementation for Migrate DB On StartUp and Jobs Approach #544

wants to merge 14 commits into from

Conversation

rhkp
Copy link
Contributor

@rhkp rhkp commented Oct 2, 2024 •
edited by ricardozanini
Loading

@rhkp rhkp requested a review from ricardozanini as a code owner October 2, 2024 14:38
ricardozanini
ricardozanini reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a further look later.

api/v1alpha08/sonataflowplatform_services_types.go Outdated Show resolved Hide resolved
@ricardozanini
Copy link
Member

@rhkp can you please rebase? e2e now should be faster now.

ricardozanini
ricardozanini requested changes Oct 4, 2024
View reviewed changes
api/v1alpha08/sonataflow_persistence_types.go Outdated Show resolved Hide resolved
api/v1alpha08/sonataflowplatform_types.go Outdated Show resolved Hide resolved
api/v1alpha08/sonataflowplatform_types.go Outdated Show resolved Hide resolved
internal/controller/platform/dbMigratorJob.go Show resolved Hide resolved
internal/controller/platform/dbMigratorJob.go Outdated Show resolved Hide resolved
internal/controller/platform/dbMigratorJob.go Outdated Show resolved Hide resolved
internal/controller/platform/k8s.go Outdated Show resolved Hide resolved
internal/controller/platform/services/secrets.go Outdated Show resolved Hide resolved
internal/controller/platform/services/services.go Outdated Show resolved Hide resolved
internal/controller/platform/services/services.go Outdated Show resolved Hide resolved
ricardozanini
ricardozanini requested changes Oct 8, 2024
View reviewed changes
api/v1alpha08/sonataflowplatform_types.go Outdated Show resolved Hide resolved
api/v1alpha08/sonataflowplatform_types.go Outdated Show resolved Hide resolved
internal/controller/cfg/controllers_cfg.go Outdated Show resolved Hide resolved
internal/controller/platform/dbMigratorJob.go Outdated Show resolved Hide resolved
internal/controller/platform/services/services.go Outdated Show resolved Hide resolved
internal/controller/platform/services/services.go Outdated Show resolved Hide resolved
@rhkp rhkp mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini requested changes

@wmedvede wmedvede Awaiting requested review from wmedvede

@jakubschwan jakubschwan Awaiting requested review from jakubschwan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rhkp @ricardozanini