Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] Drools DISCLAIMER-BINARY lists files that are no longer in the source release #1622

Closed
pjfanning opened this issue Nov 18, 2024 · 6 comments · Fixed by apache/incubator-kie-drools#6157
Assignees
Labels
apache:compliance Related to Apache compliance in terms of legal, governance, processes etc

Comments

@pjfanning
Copy link

https://github.com/tkobayas/drools/blob/ceb92b6fd5de0034e1abbd72c6c06bfd3aadd758/DISCLAIMER-BINARY

Probably best to remove this file - none of the listed jars appear in the source release. The name is also not a good name for this file. DISCLAIMER is used for very specific text provided by the Apache Incubator team.

@pjfanning
Copy link
Author

fyi @porcelli @LightGuard @tkobayas

@porcelli
Copy link
Member

@pjfanning I think those are reflecting the current state of main, not 10.0.0

@pjfanning
Copy link
Author

The filename is wrong and this should not be included in the source release if it is kept.

I think you would be better off centralising this in your build docs.

@LightGuard
Copy link

Did this get fixed with apache/incubator-kie-drools#6153 ?

@pjfanning
Copy link
Author

Did this get fixed with apache/incubator-kie-drools#6153 ?

No. This was raised because this issue was not addressed in the PR.

@tkobayas
Copy link

Removing DISCLAIMER-BINARY with the PR apache/incubator-kie-drools#6157

Also filed apache/incubator-kie-drools#6158 for removing the jars on main.

@yesamer yesamer added the apache:compliance Related to Apache compliance in terms of legal, governance, processes etc label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache:compliance Related to Apache compliance in terms of legal, governance, processes etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants