-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6951][CORE][CH] Move CustomerExpressionTransformer to CH backend #6993
Conversation
Run Gluten Clickhouse CI |
@liujiayi771 @Yohahaha @ulysses-you @kecookier @zhli1142015 (and all Velox backend users/developers) Please let me know if you rely on the feature. Otherwise we'll remove then. |
@zzcclp What do you think about this? Thanks. |
We are not rely on this functionality for now. |
Run Gluten Clickhouse CI |
+1 |
Run Gluten Clickhouse CI |
let me move test to backends clickhouse first. |
+1 |
please move |
Run Gluten Clickhouse CI |
I am moving it. It caused Velox's test failure. |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zzcclp Thanks! |
CustomerExpressionTransformer was added to core module in #1937 however is not used by Velox backend for long time. Propose to move its code and planner rules to CH backend.
Changes:
a.g.s.c.extended.expressions.transformer
from Velox backendCustomerExpressionTransformer
from core to CH backend