[VL] Remove config a.g.s.c.extended.columnar.transform.rules and a.g.s.c.extended.columnar.post.rules from Velox backend
#6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.c.extended.columnar.post.rules
|
Run Gluten Clickhouse CI |
|
@liujiayi771 @Yohahaha @ulysses-you @kecookier @zhli1142015 (and all Velox backend users/developers) Please let me know if you rely on these config options. Otherwise we'll remove then. |
zhztheplayer
changed the title
zhztheplayer
changed the title
a.g.s.c.extended.columnar.transform.rules and s.g.s.c.extended.columnar.post.rules from Velox backend
zhztheplayer
changed the title
a.g.s.c.extended.columnar.transform.rules and s.g.s.c.extended.columnar.post.rules from Velox backenda.g.s.c.extended.columnar.transform.rules and a.g.s.c.extended.columnar.post.rules from Velox backend
JkSelf
approved these changes
Aug 23, 2024
|
Will merge. Please still comment if any issues. |
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
…rules` and `a.g.s.c.extended.columnar.post.rules` from Velox backend (apache#6991) Closes apache#6990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6990
Remove config options
a.g.s.c.extended.columnar.transform.rulesanda.g.s.c.extended.columnar.post.rulesfrom Velox backend as they aren't used.The options will still work with CH backend.