-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6840][CH] Enable cache files for hdfs #6841
Conversation
Run Gluten Clickhouse CI |
5 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
ff93bda
to
25cacc5
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
1b545be
to
8793273
Compare
cpp-ch/local-engine/Storages/SubstraitSource/ReadBufferBuilder.cpp
Outdated
Show resolved
Hide resolved
8793273
to
2a95447
Compare
Run Gluten Clickhouse CI |
@@ -85,6 +85,16 @@ DB::ContextMutablePtr QueryContextManager::currentQueryContext() | |||
return query_map.get(id)->query_context; | |||
} | |||
|
|||
std::shared_ptr<DB::ThreadGroup> QueryContextManager::currentThreadGroup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要这么复杂,直接返回currentThread::getGroup,不存在报错即可,这里会保证所有的线程都会attach到thread group
2a95447
to
8afe4a1
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
8afe4a1
to
f2feb52
Compare
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Run Gluten Clickhouse CI |
What changes were proposed in this pull request?
(Fixes: #6840)
新增命令
示例
注意:
_
和.
开头的文件将忽略开启缓存后,默认所有查询都会缓存,如果希望SQL级别不缓存,使用
S3缓存的配置项
统一S3和HDFS参数
新增如下配置
原有s3配置继续使用,默认配置了新参数后,原配置将不再生效
新增指标
行为修改
修改前默认true,当前改为当启用缓存时,此参数强制false。
How was this patch tested?
Test by ut