[GLUTEN-4502][VL] Allow TIMESTAMP & complex types in cast expression #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
changed the title
PHILO-HE
force-pushed
the
allow-complex-types-in-cast
branch
from
47ad4fe to
d01b685
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
PHILO-HE
force-pushed
the
allow-complex-types-in-cast
branch
2 times, most recently
from
5c70e7b to
fdf9abd
Compare
PHILO-HE
force-pushed
the
allow-complex-types-in-cast
branch
from
fdf9abd to
bf06043
Compare
|
CC @wangyum |
|
note: most of the failures seems due to window related unit tests |
PHILO-HE
force-pushed
the
allow-complex-types-in-cast
branch
from
bf06043 to
7f2b5d5
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is just an attempt to offload cast with such types involved to velox. Maybe, at least, we still need to block nested complex types.
(Fixes: #4502)
How was this patch tested?
Existing tests & new test.