IGNITE-23562 SQL Calcite: Fix partition reservation for index-count-scan (on top of refactoring) #11651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alex-plekhanov
force-pushed
the
ignite-23562-new
branch
from
88805c5
to
3efc652
Compare
# Conflicts: # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheIndexImpl.java
Vladsz83
reviewed
Nov 26, 2024
...e/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexCountScan.java
Outdated
Show resolved
Hide resolved
...nite/internal/processors/query/calcite/integration/PartitionsReservationIntegrationTest.java
Show resolved
Hide resolved
| /** */ | ||
| @Test | ||
| public void testIndexCount() throws Exception { | ||
| checkPartitionsReservationRelease( |
There was a problem hiding this comment.
I've put if (true) return createIterator(); in AbstractCacheScan#iterator(). This test works. Is it ok?
There was a problem hiding this comment.
If you run it several times it fails with a high failure rate:
java.lang.AssertionError: Collections are not equal (position 0):
Expected: [[1600000]]
Actual: [[1599889]]
at org.junit.Assert.fail(Assert.java:88)
at org.apache.ignite.internal.processors.query.calcite.QueryChecker.assertEqualsCollections(QueryChecker.java:479)
at org.apache.ignite.internal.processors.query.calcite.QueryChecker.check(QueryChecker.java:454)
at org.apache.ignite.internal.processors.query.calcite.integration.PartitionsReservationIntegrationTest$1.run(PartitionsReservationIntegrationTest.java:118)
Vladsz83
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.