Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I find if there is residual in the table scan/plan files? #785

Open
maytasm opened this issue Jun 1, 2024 · 7 comments
Open

How do I find if there is residual in the table scan/plan files? #785

maytasm opened this issue Jun 1, 2024 · 7 comments

Comments

@maytasm
Copy link

maytasm commented Jun 1, 2024

Question

Table scan returns DataScan. I can call plan_files on DataScan to get a list of FileScanTask. I need to find if there are residual due to the filtering in any of the files? How do I do this? Thanks!

@maytasm
Copy link
Author

maytasm commented Jun 1, 2024

Seems like we used to have something like 4f0a5c6 but it's gone? @Fokko @TGooch44

@Fokko
Copy link
Contributor

Fokko commented Jun 3, 2024

Hey @maytasm Thanks for raising this. We don't have the ResidualEvaluator today, but it would be great to add that. We can take inspiration from Java. The code that you're referring to is gone since we have build up the expression system from the ground up.

The evaluators should be already part of the codebase. Are you interested in contributing to this?

@maytasm
Copy link
Author

maytasm commented Jun 3, 2024

@Fokko Thanks for getting back to me. I can look into contributing. I am not too familiar with the new pyiceberg rewrite (current state of this library) but was wondering if it would be something like porting over 4f0a5c6#diff-bd871c0e4a5ce5cb7edcb871e4a2b8084e44a432073c25db8b72e3ad4b94e16f ? Or do you see any blocker / difference with the old python residual evaluator and/or adding this to the FileScanTask?

@Fokko
Copy link
Contributor

Fokko commented Jun 3, 2024

@maytasm The old evaluator might be a good starting point as it is almost a 1-to-1 copy of the Java implementation. I would double check if there are additions to the Java ResidualEvaluator in the meantime

Copy link

github-actions bot commented Dec 1, 2024

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

@github-actions github-actions bot added the stale label Dec 1, 2024
@tusharchou
Copy link

@Fokko I am picking this up in #1223 #1388

@Fokko Fokko removed the stale label Dec 3, 2024
@Fokko
Copy link
Contributor

Fokko commented Dec 3, 2024

@tusharchou Thank you, I've removed the stale label 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants