Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REST catalog integration tests #1439

Open
kevinjqliu opened this issue Dec 17, 2024 · 3 comments · May be fixed by #1469
Open

Add REST catalog integration tests #1439

kevinjqliu opened this issue Dec 17, 2024 · 3 comments · May be fixed by #1469
Assignees
@AhmedNader42
Labels
good first issue Good for newcomers

Comments

@kevinjqliu
Copy link
Contributor

Feature Request / Improvement

#1434 created tests/integration/test_rest_catalog.py for integration tests with the REST catalog. Previously REST catalog tests were using mocked requests in tests/catalog/test_rest.py.

Let's add more integration tests!
@kevinjqliu kevinjqliu added the good first issue Good for newcomers label Dec 17, 2024
@kevinjqliu kevinjqliu mentioned this issue Dec 17, 2024
Merged
@AhmedNader42
Copy link
Contributor

What's going to be the implementation strategy for this integration test? I'd be happy to use my current momentum with REST Catalog to implement the rest of the tests.

My current approach would be to migrate the test_rest.py unit tests from mock to the integration test, but I'm wondering if there's any changes or additions we could include in our new integration test flow. Let me know your thoughts

@kevinjqliu
Copy link
Contributor Author

My current approach would be to migrate the test_rest.py unit tests from mock to the integration test

I think thats a great first step! Generally, testing via mocked requests is not as resilient as testing against a REST server. Let's move all the mocked tests into the integration rest test.

Would you like to work on this?

@AhmedNader42
Copy link
Contributor

Sounds good! Yes, I'll work on it

@AhmedNader42 AhmedNader42 linked a pull request Dec 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AhmedNader42 AhmedNader42

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rest catalog integration testing AhmedNader42/iceberg-python
2 participants
@kevinjqliu @AhmedNader42