Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PyIceberg release process #1306

Open
kevinjqliu opened this issue Nov 8, 2024 · 4 comments · Fixed by #1359
Open

Improve PyIceberg release process #1306

kevinjqliu opened this issue Nov 8, 2024 · 4 comments · Fixed by #1359
Assignees

Comments

@kevinjqliu
Copy link
Contributor

Feature Request / Improvement

Similar to #872

iceberg-go has a really nice release script https://github.com/apache/iceberg-go/blob/adc8193de3299b04c9763c2fba529a7b94d080ce/dev/release/release_rc.sh#L4

As the release manager for 0.8.0, I also took some notes on the release process and what we can improve
PyIceberg 0.8.0 release notes

@kevinjqliu
Copy link
Contributor Author

reopening this to track further improvements

@kevinjqliu kevinjqliu reopened this Dec 5, 2024
@kevinjqliu
Copy link
Contributor Author

#1391 captures improvements to build both PyPI and SVN artifacts in 1 GitHub action run and avoid problems like setting the wrong version/RC. The action is also now automatically run on relevant tag push.

The final release process should look something like this:

  • prepare local branch for release (main for major/minor, branch for patch release)
  • Create and push tag with RC (e.g. 0.8.1rc1)
  • Tag push automatically triggers the GitHub Action
  • Github action builds artifacts for both SVN and PyPI
  • Download the SVN artifact, create checksum and signature, and upload to SVN dev dist
  • Download Pypi artifact and upload it to PyPi
  • Send vote email
  • Once passed, download the artifact from SVN dev dist, upload it to SVN release dist, and PyPI
  • If a new RC is needed, create and push another tag with RC (e.g. 0.8.1rc2)

@kevinjqliu
Copy link
Contributor Author

based on the devlist discussion https://lists.apache.org/thread/oowhcfwv3fcjzdzm76tbn99k5q84mr75
we'd also want to publish nightly build to PyPi (#872)

This can be done by reusing pypi_build_artifacts and pypi_merge_artifacts and uploading the final artifact to PyPi. Will work on this once #1391 is in

@kevinjqliu
Copy link
Contributor Author

The final release process should look something like this:

  • prepare local branch for release (main for major/minor, branch for patch release)
  • Create and push tag with RC (e.g. 0.8.1rc1)
  • Tag push automatically triggers the GitHub Action
  • Github action builds artifacts for both SVN and PyPI
  • Download the SVN artifact, create checksum and signature, and upload to SVN dev dist
  • Download Pypi artifact and upload it to PyPi
  • Send vote email
  • Once passed, download the artifact from SVN dev dist, upload it to SVN release dist, and PyPI
  • If a new RC is needed, create and push another tag with RC (e.g. 0.8.1rc2)

This can be further simplified with make publish-rc, which takes input VERSION and RC. Creates RC artifacts and publish to SVN and PyPi

  • Create the tag based on the current branch.
  • Checks main branch is used for major/minor, and the feature branch is used for patch i.e. 0.8.x.
  • Push tag to trigger GitHub action run
  • Watch run
  • Download artifacts
  • Sign/Checksum/Upload to svn
  • Upload to PyPI

After the vote passes, use make promote-rc, which takes input VERSION and RC. Download RC artifact from dev SVN, upload to release SVN and PyPi

  • Download artifacts from SVN
  • Upload to svn
  • Upload to PyPi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant