Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MetricManager #1623

Open
jiacai2050 opened this issue Jan 15, 2025 · 0 comments
Open

Implement MetricManager #1623

jiacai2050 opened this issue Jan 15, 2025 · 0 comments
Assignees
@zealchen
Labels
A-metric-engine Area: Metric Engine

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Jan 15, 2025 •
edited
Loading

The main task of MetricManager is to manage metric name of a sample, it will:

  1. Calculate the id for metric name, using seahash. Since there is no field concept in prometheus, we could use a hard-coded one, such as value, and its type is f64.
  2. Persist new name to storage. For existing metric name, we should avoid this step, since it will involve IO operation.
  3. In order to support 2, we need to add a cache, and when server start up, we load all existing metric name into cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zealchen zealchen

Labels
A-metric-engine Area: Metric Engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jiacai2050 @zealchen