Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] In the Gravitino CLI/Java API you can delete the anoymous user #5932

Open
justinmclean opened this issue Dec 20, 2024 · 9 comments · May be fixed by #6359
Open

[Improvement] In the Gravitino CLI/Java API you can delete the anoymous user #5932

justinmclean opened this issue Dec 20, 2024 · 9 comments · May be fixed by #6359
Assignees
@chenyuan99
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

The Gravitino CLI allows you to delete the anonymous user. It does ask if are you sure, but this can have bad side effects.

If you try to create a role after this you get the error:

Failed to operate role  [admin] operation [CREATE] under metalake [metalake_demo], reason [Current user anonymous doesn't exist in the metalake metalake_demo, you should add the user to the metalake first]

You can recreate a user called anonymous to fix this error, but I'm not sure if that has other side effects. I'm assuming this may be an issue with the REST interface and Java API and not just the CLI.

How should we improve?

Change the Java API so this is not possible?
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Dec 20, 2024
@chenyuan99
Copy link
Contributor

Hey @justinmclean could I pick this up?

@justinmclean
Copy link
Member Author

@chenyuan99, how are you going with this?

@chenyuan99
Copy link
Contributor

I am still reading through the code to identify where to change.

@Abyss-lord
Copy link
Contributor

@justinmclean It looks like anoymous users can be removed from the main branch for now
Image

@justinmclean
Copy link
Member Author

Yes the idea is to stop that from happening

@Abyss-lord
Copy link
Contributor

Yes the idea is to stop that from happening

@justinmclean IMHO, I think it's possible to check on the client side if the user is anoymous, give a prompt and quit if it is, and take action if it's not.

@justinmclean
Copy link
Member Author

Yes, that is one approach we could take.

@Abyss-lord
Copy link
Contributor

Yes, that is one approach we could take.

should we add some logic in command level ?

@justinmclean
Copy link
Member Author

I would add it in the verify method using AreYouSure if possible.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 23, 2025
@Abyss-lord
[apache#5932] improve(CLI): Fix the CLI delete the anonymous user
953a66e 
Fix the CLI  delete the anonymous user
@Abyss-lord Abyss-lord linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenyuan99 chenyuan99

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5932] improve(CLI): Fix the CLI delete the anonymous user Abyss-lord/gravitino
3 participants
@justinmclean @chenyuan99 @Abyss-lord