Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](nereids) Fix deletestmt getting catalog #32701

Merged
merged 2 commits into from
Mar 26, 2024
Merged

[Fix](nereids) Fix deletestmt getting catalog #32701

merged 2 commits into from
Mar 26, 2024

Conversation

feiniaofeiafei
Copy link
Contributor

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

morrySnow
morrySnow reviewed Mar 22, 2024
View reviewed changes
regression-test/suites/external_table_p0/jdbc/test_switch_catalog_and_delete_internal.groovy Outdated Show resolved Hide resolved
regression-test/suites/external_table_p0/jdbc/test_switch_catalog_and_delete_internal.groovy Outdated
String driver_url = "https://${bucket}.${s3_endpoint}/regression/jdbc_driver/mysql-connector-java-8.0.25.jar"
if (enabled != null && enabled.equalsIgnoreCase("true")) {
// 0.create internal db and table
sql "create database maldb;"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe u could use current context database to avoid create database

String db = context.config.getDbNameByFile(new File(context.file))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37566 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3f1d6228dec91ce5ecd7f5d8315421f63aa127e5, data reload: false

------ Round 1 ----------------------------------
q1	17682	4221	4061	4061
q2	2107	153	152	152
q3	10584	1152	1153	1152
q4	10227	770	776	770
q5	7456	2936	2993	2936
q6	202	124	123	123
q7	1028	592	560	560
q8	9352	2002	1927	1927
q9	7240	6608	6518	6518
q10	8434	3454	3581	3454
q11	434	221	214	214
q12	428	193	197	193
q13	17801	2866	2884	2866
q14	238	202	212	202
q15	512	454	460	454
q16	486	368	369	368
q17	942	594	523	523
q18	7123	6474	6335	6335
q19	1551	1375	1425	1375
q20	544	261	269	261
q21	3534	2830	2950	2830
q22	339	293	292	292
Total cold run time: 108244 ms
Total hot run time: 37566 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4092	4037	4019	4019
q2	332	228	231	228
q3	2942	2860	2841	2841
q4	1831	1591	1579	1579
q5	5287	5336	5297	5297
q6	193	118	117	117
q7	2255	1889	1814	1814
q8	3127	3259	3270	3259
q9	8648	8639	8639	8639
q10	3762	3814	3749	3749
q11	557	456	443	443
q12	735	545	540	540
q13	16907	2865	2876	2865
q14	278	249	257	249
q15	488	453	463	453
q16	458	427	426	426
q17	1699	1478	1459	1459
q18	7578	7059	7044	7044
q19	1613	1547	1491	1491
q20	1895	1730	1711	1711
q21	4720	4704	4726	4704
q22	534	457	455	455
Total cold run time: 69931 ms
Total hot run time: 53382 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185558 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3f1d6228dec91ce5ecd7f5d8315421f63aa127e5, data reload: false

query1	935	361	351	351
query2	7389	1909	1934	1909
query3	6709	212	218	212
query4	31720	21159	21114	21114
query5	4298	485	393	393
query6	272	170	164	164
query7	4628	290	284	284
query8	221	177	172	172
query9	9225	2280	2249	2249
query10	565	252	247	247
query11	17295	14208	14270	14208
query12	143	88	85	85
query13	1628	415	398	398
query14	12475	11462	10396	10396
query15	261	198	193	193
query16	8220	266	255	255
query17	1998	577	547	547
query18	2068	288	279	279
query19	351	146	152	146
query20	89	86	90	86
query21	204	127	128	127
query22	5055	4865	4833	4833
query23	33358	32923	32853	32853
query24	10650	2865	2848	2848
query25	611	385	386	385
query26	1160	152	167	152
query27	2573	347	356	347
query28	7440	1853	1807	1807
query29	894	640	635	635
query30	293	162	162	162
query31	946	753	741	741
query32	93	58	55	55
query33	774	263	255	255
query34	1045	490	484	484
query35	817	603	617	603
query36	1055	881	894	881
query37	125	77	75	75
query38	3611	3423	3445	3423
query39	1478	1433	1391	1391
query40	212	114	113	113
query41	53	46	48	46
query42	105	95	100	95
query43	471	456	438	438
query44	1177	716	714	714
query45	284	264	252	252
query46	1115	718	706	706
query47	1919	1857	1844	1844
query48	455	346	350	346
query49	1105	346	332	332
query50	764	366	364	364
query51	6758	6552	6550	6550
query52	106	95	96	95
query53	351	282	279	279
query54	310	241	250	241
query55	79	78	78	78
query56	252	231	241	231
query57	1189	1150	1151	1150
query58	240	208	217	208
query59	2821	2598	2539	2539
query60	274	321	262	262
query61	121	118	115	115
query62	657	447	457	447
query63	309	275	280	275
query64	5866	4141	4099	4099
query65	3074	2986	3043	2986
query66	865	356	351	351
query67	15258	14846	14916	14846
query68	7011	511	512	511
query69	618	365	377	365
query70	1282	1209	1159	1159
query71	512	272	275	272
query72	6400	2743	2540	2540
query73	714	304	306	304
query74	8043	6617	6613	6613
query75	4137	2937	2899	2899
query76	4895	941	914	914
query77	656	253	263	253
query78	11148	10118	10140	10118
query79	10256	522	519	519
query80	1894	394	386	386
query81	524	218	212	212
query82	878	202	194	194
query83	215	142	143	142
query84	292	77	83	77
query85	1518	313	303	303
query86	481	291	288	288
query87	3744	3504	3556	3504
query88	4905	2270	2274	2270
query89	506	370	372	370
query90	1984	174	174	174
query91	169	131	138	131
query92	65	47	46	46
query93	7278	484	473	473
query94	1237	173	175	173
query95	423	322	330	322
query96	598	272	278	272
query97	3083	2877	2874	2874
query98	233	218	209	209
query99	1185	924	926	924
Total cold run time: 315746 ms
Total hot run time: 185558 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 3f1d6228dec91ce5ecd7f5d8315421f63aa127e5 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       20.6 seconds inserted 10000000 Rows, about 485K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit e834b45 into apache:master Mar 26, 2024
28 of 34 checks passed
yiguolei pushed a commit that referenced this pull request Mar 26, 2024
@feiniaofeiafei @Doris-Extras
[Fix](nereids) Fix deletestmt getting catalog (#32701)
b5a1914
@feiniaofeiafei feiniaofeiafei mentioned this pull request Mar 26, 2024
Merged
morrySnow pushed a commit that referenced this pull request Mar 29, 2024
@feiniaofeiafei
[Fix](nereids) Fix deletestmt getting catalog (#32833)
f7670d6 
cherry-pick #32701
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@feiniaofeiafei
[Fix](nereids) Fix deletestmt getting catalog (apache#32833)
6734ca4 
cherry-pick apache#32701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.8-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@feiniaofeiafei @doris-robot @starocean999 @morrySnow @xiaokang