Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix] Add initialization list to the copy constructor of ScanPredicate in jni_connect.h #46666 #46726

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2025

Cherry-picked from #46666

…e in jni_connect.h (#46666)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
The copy constructor of `ScanPredicate` in `jni_connect.h` does not use
an initialization list, which might result in uninitialized member
variables or unintended behavior.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 9, 2025
@dataroaring dataroaring reopened this Jan 9, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40931 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8e8140507d322374149426428b5d7a10bab79db8, data reload: false

------ Round 1 ----------------------------------
q1	17579	7790	7249	7249
q2	2033	173	168	168
q3	10608	1097	1198	1097
q4	10544	774	691	691
q5	7746	2869	2805	2805
q6	239	145	143	143
q7	997	609	604	604
q8	9350	1929	1998	1929
q9	6536	6370	6408	6370
q10	7039	2339	2329	2329
q11	468	265	258	258
q12	410	213	207	207
q13	17774	2969	3017	2969
q14	249	209	209	209
q15	573	534	523	523
q16	684	634	614	614
q17	978	534	566	534
q18	7254	6734	6806	6734
q19	1409	1081	1070	1070
q20	479	207	196	196
q21	4045	3280	3237	3237
q22	1094	995	1026	995
Total cold run time: 108088 ms
Total hot run time: 40931 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7251	7173	7154	7154
q2	333	228	228	228
q3	2910	2948	2933	2933
q4	2050	1863	1880	1863
q5	5707	5719	5740	5719
q6	223	139	145	139
q7	2231	1805	1849	1805
q8	3331	3543	3521	3521
q9	8882	8857	8827	8827
q10	3598	3553	3564	3553
q11	600	495	485	485
q12	804	644	668	644
q13	11238	3183	3181	3181
q14	291	285	286	285
q15	560	512	530	512
q16	695	683	675	675
q17	1858	1623	1588	1588
q18	8226	7779	7622	7622
q19	1680	1660	1555	1555
q20	2100	1858	1862	1858
q21	5614	5315	5403	5315
q22	1145	1061	1051	1051
Total cold run time: 71327 ms
Total hot run time: 60513 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196689 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8e8140507d322374149426428b5d7a10bab79db8, data reload: false

query1	1290	917	921	917
query2	6239	2107	2002	2002
query3	10986	4507	4550	4507
query4	66806	28868	23704	23704
query5	4969	466	454	454
query6	419	184	181	181
query7	5511	315	305	305
query8	319	234	234	234
query9	8846	2684	2679	2679
query10	448	271	258	258
query11	17049	15252	15897	15252
query12	163	109	101	101
query13	1490	468	435	435
query14	9759	8382	7246	7246
query15	199	181	184	181
query16	7090	493	517	493
query17	1059	603	611	603
query18	2049	329	330	329
query19	211	166	174	166
query20	118	121	120	120
query21	212	108	110	108
query22	5111	4492	4553	4492
query23	34545	34037	34224	34037
query24	6890	2893	2929	2893
query25	516	407	411	407
query26	660	169	172	169
query27	1798	357	352	352
query28	4251	2484	2446	2446
query29	682	459	419	419
query30	242	161	161	161
query31	978	803	862	803
query32	68	55	55	55
query33	489	304	291	291
query34	921	508	538	508
query35	861	727	724	724
query36	1109	954	962	954
query37	123	72	72	72
query38	4187	4074	4028	4028
query39	1512	1460	1446	1446
query40	205	99	98	98
query41	50	48	50	48
query42	116	100	99	99
query43	540	500	491	491
query44	1164	820	827	820
query45	184	168	169	168
query46	1173	733	733	733
query47	2041	1912	1980	1912
query48	481	382	379	379
query49	725	386	375	375
query50	861	428	430	428
query51	7401	7265	7273	7265
query52	96	86	86	86
query53	263	178	182	178
query54	543	461	443	443
query55	76	72	77	72
query56	246	241	238	238
query57	1272	1077	1121	1077
query58	227	207	230	207
query59	3106	3030	3014	3014
query60	271	250	263	250
query61	110	102	109	102
query62	774	654	671	654
query63	224	188	202	188
query64	1348	673	624	624
query65	3260	3214	3163	3163
query66	696	303	297	297
query67	15897	15619	15756	15619
query68	3672	576	579	576
query69	449	279	259	259
query70	1209	1129	1070	1070
query71	354	256	252	252
query72	6388	2563	3825	2563
query73	744	342	349	342
query74	10049	9054	8962	8962
query75	3348	2669	2661	2661
query76	1852	1124	1123	1123
query77	483	278	264	264
query78	10561	9632	9665	9632
query79	1177	589	598	589
query80	796	430	420	420
query81	512	249	235	235
query82	878	117	120	117
query83	163	149	141	141
query84	279	95	82	82
query85	791	291	293	291
query86	326	284	293	284
query87	4397	4286	4317	4286
query88	3575	2391	2347	2347
query89	418	292	291	291
query90	2067	189	179	179
query91	183	147	149	147
query92	59	50	51	50
query93	1080	535	546	535
query94	775	302	300	300
query95	352	258	253	253
query96	615	274	283	274
query97	3343	3234	3132	3132
query98	214	195	204	195
query99	1566	1321	1277	1277
Total cold run time: 316200 ms
Total hot run time: 196689 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.51 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8e8140507d322374149426428b5d7a10bab79db8, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.51	0.51	0.52
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.05	0.03
query9	0.55	0.50	0.50
query10	0.55	0.56	0.58
query11	0.14	0.10	0.11
query12	0.14	0.12	0.11
query13	0.61	0.61	0.59
query14	2.95	2.94	2.94
query15	0.89	0.83	0.83
query16	0.40	0.38	0.38
query17	0.99	1.06	1.04
query18	0.23	0.21	0.21
query19	1.83	1.88	1.99
query20	0.01	0.01	0.01
query21	15.36	0.58	0.56
query22	2.69	2.62	2.26
query23	17.03	1.13	0.85
query24	2.80	0.98	1.53
query25	0.16	0.22	0.15
query26	0.38	0.14	0.13
query27	0.05	0.05	0.05
query28	10.51	1.11	1.08
query29	12.57	3.22	3.19
query30	0.25	0.06	0.06
query31	2.87	0.39	0.37
query32	3.25	0.46	0.46
query33	2.94	2.98	3.00
query34	16.81	4.48	4.52
query35	4.60	4.49	4.59
query36	0.67	0.49	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 106.4 s
Total hot run time: 33.51 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants