Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression-test](profile) Add some flaky profile tests back #46720

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Jan 9, 2025

What problem does this PR solve?

Related PR: #42396

adaptive_pipeline_task_serial_read_on_limit is refactored by using show query profile

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the revert-revert-profile-test branch from 670107a to fe72294 Compare January 9, 2025 13:06
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh zhiqiang-hhhh marked this pull request as ready for review January 10, 2025 05:08
@zhiqiang-hhhh zhiqiang-hhhh changed the title [WIP](profile) Add some flaky profile test back [regression-test](profile) Add some flaky profile test back Jan 10, 2025
@zhiqiang-hhhh zhiqiang-hhhh changed the title [regression-test](profile) Add some flaky profile test back [regression-test](profile) Add some flaky profile tests back Jan 10, 2025
@zhiqiang-hhhh
Copy link
Contributor Author

run p0

@zhiqiang-hhhh zhiqiang-hhhh marked this pull request as draft January 10, 2025 10:24
@zhiqiang-hhhh zhiqiang-hhhh force-pushed the revert-revert-profile-test branch from 7c997be to 7a38102 Compare January 13, 2025 02:11
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh zhiqiang-hhhh marked this pull request as ready for review January 13, 2025 08:47
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo wangbo merged commit 1b125cd into apache:master Jan 14, 2025
25 of 26 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the revert-revert-profile-test branch January 14, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants