-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enchement](api)Change the behavior of follower http api redirect to master to follower request master. #45921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…master to follower request master.
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32355 ms
|
TPC-DS: Total hot run time: 198180 ms
|
ClickBench: Total hot run time: 31.25 s
|
run buildall |
TPC-H: Total hot run time: 32911 ms
|
TPC-DS: Total hot run time: 196931 ms
|
ClickBench: Total hot run time: 31.36 s
|
hubgeter
force-pushed
the
fe_http_forword
branch
from
December 30, 2024 14:43
e18e55c
to
fc94210
Compare
run buildall |
run buildall |
TPC-H: Total hot run time: 32325 ms
|
TPC-DS: Total hot run time: 190164 ms
|
ClickBench: Total hot run time: 31.86 s
|
run buildall |
TPC-H: Total hot run time: 32609 ms
|
TPC-DS: Total hot run time: 189481 ms
|
ClickBench: Total hot run time: 31.14 s
|
morningman
approved these changes
Jan 2, 2025
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Indicates a PR has been approved by one committer.
reviewed
labels
Jan 2, 2025
PR approved by anyone and no changes requested. |
zy-kkk
approved these changes
Jan 2, 2025
CalvinKirs
approved these changes
Jan 2, 2025
morningman
added
kind/behavior-changed
dev/3.0.x-experimental
and removed
dev/3.0.x
labels
Jan 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…master to follower request master. (#45921) ### What problem does this PR solve? Problem Summary: Change the behavior of follower http api redirecting to master to follower requesting master. Before this, when client sends http api request to follower, some api interfaces will send redirect request to client, and client will send request to master. However, in k8s scenario, there may be network disconnection between client and master, so this pr changes this behavior. ### Release note Change the behavior of follower http api redirecting to master to follower requesting master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.x-experimental
dev/3.0.x-experimental
kind/behavior-changed
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Change the behavior of follower http api redirecting to master to follower requesting master.
Before this, when client sends http api request to follower, some api interfaces will send redirect request to client, and client will send request to master. However, in k8s scenario, there may be network disconnection between client and master, so this pr changes this behavior.
Release note
Change the behavior of follower http api redirecting to master to follower requesting master.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)