Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) set correct sort key for aggregate #45369 branch-3.0 #45706

Open
wants to merge 2 commits into
base: branch-3.0
Choose a base branch
from

Conversation

englefly
Copy link
Contributor

What problem does this PR solve?

pick#45369
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

run buildall

@englefly
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40113 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit edae3f10c966e34624900591b6225b669e70b608, data reload: false

------ Round 1 ----------------------------------
q1	17572	7299	7207	7207
q2	2068	164	178	164
q3	10712	1063	1140	1063
q4	10553	747	790	747
q5	8112	2881	2822	2822
q6	238	149	148	148
q7	968	615	626	615
q8	9576	1897	1896	1896
q9	7949	6320	6377	6320
q10	6983	2243	2266	2243
q11	455	262	261	261
q12	398	207	202	202
q13	17782	2953	2958	2953
q14	242	210	213	210
q15	569	518	515	515
q16	695	603	608	603
q17	954	573	488	488
q18	7177	6652	6563	6563
q19	4045	933	1097	933
q20	460	204	190	190
q21	3903	3044	3209	3044
q22	1099	955	926	926
Total cold run time: 112510 ms
Total hot run time: 40113 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7371	7211	7235	7211
q2	332	226	235	226
q3	3005	2853	2856	2853
q4	2104	1776	1756	1756
q5	5631	5682	5714	5682
q6	249	149	142	142
q7	2177	1734	1725	1725
q8	3363	3506	3371	3371
q9	8773	8839	8759	8759
q10	3516	3511	3704	3511
q11	590	492	510	492
q12	804	632	640	632
q13	16479	3169	3147	3147
q14	308	263	268	263
q15	577	530	529	529
q16	728	685	662	662
q17	1820	1570	1589	1570
q18	8052	7788	7426	7426
q19	3444	1616	1535	1535
q20	2066	1862	1822	1822
q21	5344	5314	5372	5314
q22	1111	1016	987	987
Total cold run time: 77844 ms
Total hot run time: 59615 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195294 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit edae3f10c966e34624900591b6225b669e70b608, data reload: false

query1	1283	927	911	911
query2	6221	2189	2127	2127
query3	10816	4186	4190	4186
query4	68889	30205	23366	23366
query5	5735	447	458	447
query6	518	162	159	159
query7	6356	314	312	312
query8	335	232	243	232
query9	9268	2670	2666	2666
query10	554	264	272	264
query11	18332	15418	15643	15418
query12	160	105	99	99
query13	1591	436	411	411
query14	10848	6716	7181	6716
query15	217	185	177	177
query16	7455	501	505	501
query17	1094	574	579	574
query18	1956	312	328	312
query19	213	151	161	151
query20	116	111	109	109
query21	67	44	43	43
query22	4672	4485	4466	4466
query23	34982	33831	34143	33831
query24	5766	2999	2943	2943
query25	552	430	402	402
query26	690	170	171	170
query27	2016	344	346	344
query28	4715	2528	2515	2515
query29	702	474	477	474
query30	255	167	161	161
query31	1024	836	815	815
query32	64	56	54	54
query33	435	280	273	273
query34	915	489	491	489
query35	841	758	725	725
query36	1075	951	945	945
query37	119	68	69	68
query38	4151	4034	3981	3981
query39	1526	1445	1457	1445
query40	139	83	82	82
query41	47	47	44	44
query42	113	100	103	100
query43	550	515	516	515
query44	1171	797	780	780
query45	181	168	181	168
query46	1152	719	727	719
query47	1964	1847	1903	1847
query48	461	372	376	372
query49	711	379	388	379
query50	831	413	399	399
query51	7187	7168	7207	7168
query52	95	92	92	92
query53	257	184	182	182
query54	553	441	445	441
query55	76	78	74	74
query56	256	228	236	228
query57	1197	1125	1089	1089
query58	200	197	204	197
query59	3298	3065	3199	3065
query60	271	247	253	247
query61	103	102	108	102
query62	780	675	684	675
query63	203	182	194	182
query64	1861	666	605	605
query65	3238	3121	3183	3121
query66	742	304	296	296
query67	15722	15098	15034	15034
query68	4590	561	540	540
query69	424	246	257	246
query70	1143	1103	1146	1103
query71	367	251	248	248
query72	6637	3883	3884	3883
query73	775	338	342	338
query74	10228	8928	8822	8822
query75	3294	2625	2652	2625
query76	2586	1162	1073	1073
query77	489	266	260	260
query78	10713	9748	9441	9441
query79	8389	589	599	589
query80	1925	424	421	421
query81	544	238	234	234
query82	1293	118	109	109
query83	299	142	145	142
query84	300	91	83	83
query85	1666	291	284	284
query86	483	299	264	264
query87	4369	4292	4161	4161
query88	5816	2363	2399	2363
query89	545	290	291	290
query90	2142	184	189	184
query91	177	143	140	140
query92	63	46	48	46
query93	6621	530	533	530
query94	814	269	296	269
query95	346	251	255	251
query96	619	278	275	275
query97	3328	3129	3115	3115
query98	209	201	193	193
query99	1609	1296	1287	1287
Total cold run time: 342686 ms
Total hot run time: 195294 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants