Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud-mow) Fix the issue of missing and removing some old version delete bitmap #44300

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[fix](cloud-mow) Fix the issue of missing and removing some old version delete bitmap #44300

merged 3 commits into from
Nov 21, 2024

Conversation

hust-hhb
Copy link
Contributor

@hust-hhb hust-hhb commented Nov 19, 2024 •
edited
Loading

What problem does this PR solve?

Related PR: #40204

Problem Summary:
pr #40204 support removing old delete bitmap, however it donesn't consider boundary which will lead to miss some delete bitmap should be removed on be , it only affect local delete bitmap, the delete bitmap store in fdb is right, and these missing delete bitmaps can only be deleted by next base compaciton before this pr.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.02% (9900/26036)
Line Coverage: 29.20% (82806/283592)
Region Coverage: 28.33% (42522/150077)
Branch Coverage: 24.90% (21562/86598)
Coverage Report: http://coverage.selectdb-in.cc/coverage/afdd25134886d56c4b1d9ff02260d76b233703e0_afdd25134886d56c4b1d9ff02260d76b233703e0/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.02% (9900/26040)
Line Coverage: 29.21% (82838/283597)
Region Coverage: 28.34% (42544/150105)
Branch Coverage: 24.90% (21563/86604)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b8bdab3e720d750463982ad9e2af07579b910a66_b8bdab3e720d750463982ad9e2af07579b910a66/report/index.html

@hust-hhb
Copy link
Contributor Author

@zhannngchen already change this pr, take a look please

zhannngchen
zhannngchen approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.03% (9902/26034)
Line Coverage: 29.20% (82815/283566)
Region Coverage: 28.34% (42542/150105)
Branch Coverage: 24.91% (21569/86604)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b8bdab3e720d750463982ad9e2af07579b910a66_b8bdab3e720d750463982ad9e2af07579b910a66/report/index.html

dataroaring
dataroaring approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 867bd15 into apache:master Nov 21, 2024
26 of 28 checks passed
@hust-hhb hust-hhb mentioned this pull request Nov 22, 2024
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@hust-hhb
[fix](cloud-mow) Fix the issue of missing and removing some old versi…
8ec52e4 
…on delete bitmap (#44448)

Problem Summary:
pr #40204 support removing old
delete bitmap, however it donesn't consider boundary which will lead to
miss some delete bitmap should be removed on be , it only affect local
delete bitmap, the delete bitmap store in fdb is right, and these
missing delete bitmaps can only be deleted by next base compaciton
before this pr.
pick pr:#44300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hust-hhb @doris-robot @zhannngchen @dataroaring