Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refine](column) ColumnArray does not implement the insert data function. #43926

Merged
merged 4 commits into from
Nov 25, 2024
Merged

[refine](column) ColumnArray does not implement the insert data function. #43926

merged 4 commits into from
Nov 25, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Nov 14, 2024 •
edited
Loading

What problem does this PR solve?

ColumnArray cannot determine how many elements it contains from a single block of memory.
The original approach where the result of get data at cannot be inserted back
into insert data. Therefore, this function is not implemented directly.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Mryange
Copy link
Contributor Author

Mryange commented Nov 14, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.95% (9888/26056)
Line Coverage: 29.14% (82618/283510)
Region Coverage: 28.27% (42469/150208)
Branch Coverage: 24.86% (21543/86668)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1b90511233fa6f164032b862879d5991b58952fb_1b90511233fa6f164032b862879d5991b58952fb/report/index.html

@Mryange Mryange changed the title [only test ] remove array insert data [refine](column) ColumnArray does not implement the insert data function. Nov 14, 2024
@Mryange Mryange marked this pull request as ready for review November 14, 2024 13:05
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Contributor Author

Mryange commented Nov 14, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.96% (9886/26044)
Line Coverage: 29.13% (82594/283567)
Region Coverage: 28.27% (42466/150224)
Branch Coverage: 24.84% (21534/86680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5a5c47af4c15c9d4b2e232d9af2aef675a73898e_5a5c47af4c15c9d4b2e232d9af2aef675a73898e/report/index.html

amorynan
amorynan reviewed Nov 15, 2024
View reviewed changes
be/src/vec/columns/column_dictionary.h
@@ -158,10 +158,6 @@ class ColumnDictionary final : public COWHelper<IColumn, ColumnDictionary<T>> {
__builtin_unreachable();
}

bool is_fixed_and_contiguous() const override { return true; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this can be deleted ?
because get_raw_data() maybe depends on it?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now , only use in array.

@Mryange
Copy link
Contributor Author

Mryange commented Nov 15, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Contributor Author

Mryange commented Nov 17, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.98% (9894/26051)
Line Coverage: 29.16% (82704/283575)
Region Coverage: 28.30% (42466/150062)
Branch Coverage: 24.88% (21539/86576)
Coverage Report: http://coverage.selectdb-in.cc/coverage/087718affdd59ea55eb14357680d7e423e1d6a32_087718affdd59ea55eb14357680d7e423e1d6a32/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Nov 18, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.00% (9896/26045)
Line Coverage: 29.18% (82739/283582)
Region Coverage: 28.32% (42485/150043)
Branch Coverage: 24.89% (21549/86574)
Coverage Report: http://coverage.selectdb-in.cc/coverage/873e2529615b1305154b862d04660a266b864e61_873e2529615b1305154b862d04660a266b864e61/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Nov 18, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.02% (9896/26025)
Line Coverage: 29.17% (82700/283483)
Region Coverage: 28.31% (42480/150030)
Branch Coverage: 24.88% (21545/86580)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b5b8694c451024de451b607c238824ce055474c_7b5b8694c451024de451b607c238824ce055474c/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 8a8d37c into apache:master Nov 25, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorynan amorynan amorynan left review comments

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mryange @doris-robot @amorynan @Gabriel39 @zhangstar333