[Enhancement] (nereids)implement showCreateCatalogCommand in nereids #43068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
msridhar78
force-pushed
the
show_create_catalog1
branch
from
11dfb0d to
f28e346
Compare
msridhar78
force-pushed
the
show_create_catalog1
branch
from
f28e346 to
a9fd178
Compare
| /** | ||
| * Represents the command for SHOW CREATE CATALOG. | ||
| */ | ||
| public class ShowCreateCatalogCommand extends Command implements NoForward { |
There was a problem hiding this comment.
Suggested change
| public class ShowCreateCatalogCommand extends Command implements NoForward { | |
| public class ShowCreateCatalogCommand extends ShowCommand { |
There was a problem hiding this comment.
done - pls review
| "hosts"="http://127.0.0.1:9200" | ||
| );""" | ||
|
|
||
| result = sql """show create catalog ${catalog_name}""" |
There was a problem hiding this comment.
checkNereidsExecute("""show create catalog ${catalog_name}""")
There was a problem hiding this comment.
done - please review
msridhar78
force-pushed
the
show_create_catalog1
branch
from
a9fd178 to
d194e86
Compare
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
LiBinfeng-01
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: close #42740
implement showCreateCatalogCommand in nereids
Regression test result:
Changed Session Variables:
2024-11-19 15:27:31.633 INFO [suite-thread-1] (Suite.groovy:1316) - Execute tag: cmd, sql: show create catalog es
2024-11-19 15:27:31.641 INFO [suite-thread-1] (SuiteContext.groovy:392) - Delete /root/doris/doris/regression-test/data/nereids_p0/show/test_show_create_catalog.out
2024-11-19 15:27:31.642 INFO [suite-thread-1] (SuiteContext.groovy:394) - Generate /root/doris/doris/regression-test/data/nereids_p0/show/test_show_create_catalog.out
2024-11-19 15:27:31.665 INFO [suite-thread-1] (Suite.groovy:387) - Execute sql: drop catalog if exists es
2024-11-19 15:27:31.675 INFO [suite-thread-1] (ScriptContext.groovy:120) - Run test_show_create_catalog in /root/doris/doris/regression-test/suites/nereids_p0/show/test_show_create_catalog.groovy succeed
2024-11-19 15:27:52.891 INFO [main] (RegressionTest.groovy:281) - Start to run single scripts
2024-11-19 15:29:23.320 INFO [main] (RegressionTest.groovy:410) - Success suites:
/root/doris/doris/regression-test/suites/nereids_p0/show/test_show_create_catalog.groovy: group=p0,external,hive,external_docker,external_docker_hive, name=test_show_create_catalog
2024-11-19 15:29:23.321 INFO [main] (RegressionTest.groovy:492) - All suites success.