Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Port Whitelist naming & terms to Allowlist (or alternative) #57

Closed
King-of-Spades opened this issue Nov 24, 2020 · 5 comments
Closed

Port Whitelist naming & terms to Allowlist (or alternative) #57

King-of-Spades opened this issue Nov 24, 2020 · 5 comments

Comments

@King-of-Spades
Copy link

Feature Request

This is a request to port the Whitelist terminology in the name of this repository, code, and documentation, to Allowlist or another appropriate equivalent.

Motivation Behind Feature

  1. Whitelist though a familiar industry term, is insensitive due to bias, e.g. white == good.
  2. It's a poor descriptor since white is more abstract than allow.
  3. Allow is consistent with the operational syntax:
    <allow-navigation href="http://example.com/*" />

Feature Description

At a glance, it appears to me like most of the changes would be needed in documentation and package naming, though I haven't confirmed this.

A potential challenge is the name of the package and repository itself since that could be a breaking change downstream.

@breautek
Copy link

A potential challenge is the name of the package and repository itself since that could be a breaking change downstream.

whitelist plugin on NPM would just simply be deprecated and no longer pushed to. The repo itself I believe can be renamed and the old repo url I believe will be redirected... one would have to confirm though.

We do have a meta ticket for this located at apache/cordova#218 but that is abstract. It's good to have a ticket for this repo specifically.

@King-of-Spades
Copy link
Author

The repo itself I believe can be renamed and the old repo url I believe will be redirected... one would have to confirm though.

That's standard with GitHub repo renaming, and even mentioned on the settings for it. I've never had an issue with my own renamed repos. However, the GitHub settings do warn that it could break things, I'm not sure what integration scenarios would be potentially risky or not.

@breautek
Copy link

However, the GitHub settings do warn that it could break things, I'm not sure what integration scenarios would be potentially risky or not.

I'd have to test but I seem to recall the website will redirect but stuff like ssh urls will return with a repo does not exist kind of error.

@timbru31
Copy link
Member

AFAIK repos are redirected, username changes are not.

@jcesarmobile
Copy link
Member

The plugin is being deprecated and integrated into cordova-android with a new AllowList name apache/cordova-android#1138

So we won't be doing any renaming in this repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants