refactor(eslint): use cordova-eslint

[breautek]

Platforms affected

all

Motivation and Context

Replaces eslint config with our cordova standrd config provided by https://github.com/apache/cordova-eslint

Closes #112 and progresses apache/cordova#142

Description

Refactored src & test code to satisfy new eslint rules

Testing

Ran npm test, which runs eslint.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[timbru31]

LGTM - can we merge this? :)

[breautek]

LGTM - can we merge this? :)

I was waiting to change the version target to 3.0.0-dev first, which I haven't done yet... and I don't think we are actually have anything to release as a patch release... unless if we really want to release the npm ignore as a patch.

$ git log master...rel/2.0.2 --oneline
88ecf0b Update CONTRIBUTING.md
6561b40 chore(npm): improve ignore list (#103)
4913d83 ci: updates Node.js versions (#104)
97a4967 ci(appveyor): remove node 6, add node 12
67baf89 ci(travis): upgrade to node 8
b8ee23d chore(release): 2.0.3-dev

[timbru31]

IMHO this isn't a breaking change, could be counted as a bugfix (patch), too?

[breautek]

Convinced.