Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] add saveToGallery param on iOS for captureVideo #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chriskhongqarma
Copy link

iOS

Motivation and Context

Currently, the plugin saves the video file into gallery by default, which is not an expected behaviour in many cases. Developers should have the control over whether the file should be saved into gallery or not.
The issue for this is described in #216

Description

A new param saveToGallery is added. We get the input configuration in captureVideo, and set it to a global variable. It will be used in processVideo method to decide whether the file should be saved into gallery or not.

Testing

set saveToGallery param to 0 and 1 when capturing video, seeing whether the file is saved into gallery. Make sure it works as intended.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@chriskhongqarma chriskhongqarma marked this pull request as ready for review April 14, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant